Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options#29204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options#29204
Uh oh!
There was an error while loading.Please reload this page.
Conversation
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We were still trying to support these options via thebin/console file... but it required a lot of ugly, complex parsing. If we're going to support these options - and I think there are good use-cases for it - keeping it in core simplifies life elsewhere.
nicolas-grekas commentedNov 14, 2018
Thank you@chalasr. |
…-env and --no-debug console options (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console optionsThis reverts commit9f60ff8.This reverts commit31b5615.| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28984| License | MIT| Doc PR | -Working on recipes with@weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.Same as#29126, reverts#28745 and#28653Commits-------443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Tobion commentedNov 14, 2018
Do we need to reopen#23343 now? |
This reverts commit9f60ff8.
This reverts commit31b5615.
Working on recipes with@weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.
Same as#29126, reverts#28745 and#28653