NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()#29197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:masterfromnicolas-grekas:no-boot-cli

Nov 13, 2018

Merged

Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()#29197

nicolas-grekas merged 1 commit intosymfony:masterfromnicolas-grekas:no-boot-cli

Nov 13, 2018

Conversation

Copy link

Member

nicolas-grekas commentedNov 12, 2018

This reverts commit9253199, reversing
changes made to664a032.

Q	A
Branch?	4.2
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Replaced bysymfony/recipes#491, see description there.

Revert "bugsymfony#29154[FrameworkBundle] Define APP_ENV/APP_DEBUG …

f3c5fda

…from argv via Application::bootstrapEnv() (chalasr)"This reverts commit9253199, reversingchanges made to664a032.

nicolas-grekas added this to the4.2 milestone

Nov 12, 2018

carsonbot added Status: Needs Review FrameworkBundle Bug labels

Nov 12, 2018

Copy link

MemberAuthor

nicolas-grekas commentedNov 13, 2018

I'm proposing to revert this method because it fits nowhere: we cannot use it in the console recipe because the method is in fwb. Logic fits only inlined in bin/console as insymfony/recipes#491

ogizanagi approved these changes

Nov 13, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 13, 2018

Copy link

Member

chalasr commentedNov 13, 2018

we cannot use it in the console recipe because the method is in fwb.

We are instantiating the FWBApplication there, not sure to get the issue.
OK for me anyways

Copy link

MemberAuthor

nicolas-grekas commentedNov 13, 2018

The issue is that even if the code is in fwb, it is the console recipe that is going to reference it, because that's where bin/console is.

chalasr approved these changes

Nov 13, 2018

View reviewed changes

nicolas-grekas merged commitf3c5fda intosymfony:master

Nov 13, 2018

nicolas-grekas added a commit that referenced this pull request

Nov 13, 2018

bug#29197Revert "bug#29154[FrameworkBundle] Define APP_ENV/APP_DE…

0e242ab

…BUG from argv via Application::bootstrapEnv() (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------Revert "bug#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()This reverts commit9253199, reversingchanges made to664a032.| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Replaced bysymfony/recipes#491, see description there.Commits-------f3c5fda Revert "bug#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() (chalasr)"