Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Fix collecting messages#29196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| publicfunctiongetMessages(string$bus =null):iterable | ||
| publicfunctiongetMessages(string$bus =null):array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getMessages() in 4.1
| publicfunctiongetMessages(string$bus =null):array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why change? the BC break is allowed and the new interface better, don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OH, in order to "count" on the result. OK.
nicolas-grekas commentedNov 14, 2018
Thank you@ro0NL. |
This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] Fix collecting messages| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no-ish| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->In 4.2 there's always one dispatched message because we provide the template with a generator. Calling `{{ gen|length }}` always returns `1`BeforeAfterCommits-------bfc7d94 [Messenger] Fix collecting messages
In 4.2 there's always one dispatched message because we provide the template with a generator. Calling
{{ gen|length }}always returns1Before
After