Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] generate(null) should throw an exception#29191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?4.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28634
LicenseMIT
Doc PR-

@OskarStark
Copy link
Contributor

Should this be considered a BC break? I mean we currently don’t have a type hint here, so the behavior is changed.
I am 👍🏻 for this change but to have a smooth upgrade path without surprises, an Upgrade note should be added.

@nicolas-grekas
Copy link
MemberAuthor

3.4 throws already, that's a bug :)

@OskarStark
Copy link
Contributor

In this case... 👍🏻😉

@nicolas-grekasnicolas-grekas merged commit710aafb intosymfony:4.1Nov 13, 2018
nicolas-grekas added a commit that referenced this pull requestNov 13, 2018
…s-grekas)This PR was merged into the 4.1 branch.Discussion----------[Routing] generate(null) should throw an exception| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28634| License       | MIT| Doc PR        | -Commits-------710aafb [Routing] generate(null) should throw an exception
@fabpotfabpot mentioned this pull requestNov 16, 2018
@nicolas-grekasnicolas-grekas deleted the routing-fix-notice branchNovember 18, 2018 15:22
@fabpotfabpot mentioned this pull requestNov 26, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@OskarStark@stof@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp