Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[BUG-Fix] issue#29187 Duplication of form_errors field#29188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jawadmjn wants to merge1 commit intosymfony:4.1fromjawadmjn:issue#29187

Conversation

@jawadmjn
Copy link

QA
Bug fix?yes
New feature?no
Deprecations?yes/no
Tests pass?yes
Fixed tickets#29187
LicenseMIT

Releated toissue

@ro0NL
Copy link
Contributor

Im not sure it's the right fix, as you basically revert#24435 now

@xabbuh
Copy link
Member

In#29207 I propose a slightly different way to fix this issue.

@jawadmjn
Copy link
Author

@ro0NL Actually it is not a revert of#24435, Because in#24435 happening so many other things also.

I just fix the thing what I need as per describe in the issue29187

Because in the end, we do not want to destroy our layout when errors are appearing in formField.

@xabbuh
Copy link
Member

Thank you for your work on this. But the right "fix" to clarify the behaviour in the documentation.

@xabbuhxabbuh closed thisDec 12, 2018
@jawadmjn
Copy link
Author

@nicolas-grekas@xabbuh Hi and thanks for the feedback, but I really did not get it that how can we go with a solution when our LayOut is broken? As mentionedHere

@xabbuh
Copy link
Member

@jawadmjn You can still overwrite theform_label block to customise how and when errors are rendered.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@jawadmjn@ro0NL@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp