Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Increase priority of AddRequestFormatsListener#29186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromthewilkybarkid:request-formats-listener-priorityJan 2, 2019
Merged
[HttpKernel] Increase priority of AddRequestFormatsListener#29186
fabpot merged 1 commit intosymfony:masterfromthewilkybarkid:request-formats-listener-priorityJan 2, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesNov 20, 2018
Member
nicolas-grekas commentedNov 26, 2018
Should target 3.4 now. |
ContributorAuthor
thewilkybarkid commentedNov 26, 2018
Seems that a final 2.8 release is coming? (Just has another PR merged.) |
Member
nicolas-grekas commentedNov 26, 2018
Yes, but since this is going to be the final one, we shouldn't merge behavior changes that have even a slight breaking potential. So it's safer for 3.4 now. |
Member
fabpot commentedDec 10, 2018
As there is a potential BC break, this should be done in master. |
xabbuh approved these changesDec 13, 2018
7e9e2c3 to9bf3136CompareMember
fabpot commentedJan 2, 2019
Thank you@thewilkybarkid. |
fabpot added a commit that referenced this pull requestJan 2, 2019
…tener (thewilkybarkid)This PR was merged into the 4.3-dev branch.Discussion----------[HttpKernel] Increase priority of AddRequestFormatsListener| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#19469| License | MIT| Doc PR |Currently `AddRequestFormatsListener` has a low priority, so it won't fire before others like `RouterListener` which can create problems (eg when listening for a HTTP exception thrown by the router you don't have access for any custom types).IMO this map should be in the application rather than set on every request, but the same can be achieved by giving it a high priority. (Can't think of a reason for it to not be first...)Commits-------9bf3136 Increase priority of AddRequestFormatsListener
fabpot added a commit that referenced this pull requestJan 2, 2019
…kid)This PR was merged into the 4.3-dev branch.Discussion----------[HttpKernel] Set the default locale early| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Similar to#29186, the default locale isn't set till after the router so isn't available when trying to handle errors there (well, only the _default_ default locale is).Commits-------02c9f35 Set the default locale early
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
AddRequestFormatsListenerhas a low priority, so it won't fire before others likeRouterListenerwhich can create problems (eg when listening for a HTTP exception thrown by the router you don't have access for any custom types).IMO this map should be in the application rather than set on every request, but the same can be achieved by giving it a high priority. (Can't think of a reason for it to not be first...)