Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Fix theme settings#29184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromro0NL:profiler
Nov 12, 2018
Merged

[WebProfilerBundle] Fix theme settings#29184

nicolas-grekas merged 1 commit intosymfony:masterfromro0NL:profiler
Nov 12, 2018

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedNov 12, 2018•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28932#28935
LicenseMIT
Doc PRsymfony/symfony-docs#...

@ro0NL
Copy link
ContributorAuthor

Responsive:

image

@@ -1,6 +1,6 @@
<style>
#open-settings {
color:var(--text-muted);
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

udefined var

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedNov 12, 2018•
edited
Loading

Seems it fixes#28935 as well :)

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've just tested this in a 4.2-beta1 app and it worked perfectly! Thanks a lot Roland.

@nicolas-grekas
Copy link
Member

Thank you@ro0NL.

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestNov 12, 2018
This PR was squashed before being merged into the 4.2-dev branch (closessymfony#29184).Discussion----------[WebProfilerBundle] Fix theme settings| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |symfony#28932symfony#28935| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Commits-------8fbe85c [WebProfilerBundle] Fix theme settings
@nicolas-grekasnicolas-grekas merged commit8fbe85c intosymfony:masterNov 12, 2018
@ro0NLro0NL deleted the profiler branchNovember 12, 2018 16:48
@fabpotfabpot mentioned this pull requestNov 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL@nicolas-grekas@javiereguiluz@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp