Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update HtmlDumper.php#29176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zeyad82 wants to merge1 commit intosymfony:masterfromzeyad82:patch-1
Closed

Conversation

@zeyad82
Copy link

Made the dump search fixed as it's difficult to mange in long page.

QA
Branch?master for features / 2.8 up to 4.1 for bug fixes
Bug fix?yes/no
New feature?yes/no
BC breaks?no
Deprecations?yes/no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Made the dump search fixed as it's difficult to mange in long page.
@ro0NL
Copy link
Contributor

ro0NL commentedNov 12, 2018•
edited
Loading

Also see#28854 where we discussed this. More specifically:#28854 (comment)

Or put different; can you add e.g. a (GIF) screenshot, to see how it works now

@ro0NL
Copy link
Contributor

ro0NL commentedNov 15, 2018•
edited
Loading

Here's some work to keep the search bar fixed in view, while scrolling. But the JS needs some work still :)

Feel free to take over.. or maybe@ogizanagi can help. Im kinda stuck on this one :) though i got the CSS ok now..

Absolute min width:

image

Variable max width:

image

ro0NL@bc15c75

@chalasrchalasr added this to thenext milestoneDec 9, 2018
@fabpot
Copy link
Member

@zeyad82 Any news?

@zeyad82
Copy link
Author

@ro0NL solution seemed more inclusive.

@ro0NLro0NL mentioned this pull requestJan 25, 2019
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes#29984).Discussion----------[VarDumper] Fixed search bar| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Continuation of#28854, replaces#29176initial:![image](https://user-images.githubusercontent.com/1047696/51747953-3c9e1400-20ab-11e9-913d-d60bd59ee2d9.png)ctrl f:![image](https://user-images.githubusercontent.com/1047696/51747973-4b84c680-20ab-11e9-8d07-e6128822fbb2.png)scroll:![image](https://user-images.githubusercontent.com/1047696/51747984-550e2e80-20ab-11e9-8b54-b24109d2280a.png)tested in chrome+ffcc@ogizanagirefhttps://caniuse.com/#feat=css-stickyCommits-------99d2893 [VarDumper] Fixed search bar
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@zeyad82@ro0NL@fabpot@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp