Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables#29172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:fix_callable_descr
Nov 11, 2018
Merged

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedNov 11, 2018
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29054
LicenseMIT
Doc PRN/A

\ReflectionFunctionAbstract::getClosureScopeClass returns a\ReflectionClass instance, not the class name.

Before this patch:

--- Expected+++ Actual@@ @@-'Symfony\Component\EventDispatcher\Tests\Debug\FooListener::listen'+'Class [ <user> class Symfony\Component\EventDispatcher\Tests\Debug\FooListener ] {+  @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 28-33++  - Constants [0] {+  }++  - Static properties [0] {+  }++  - Static methods [0] {+  }++  - Properties [0] {+  }++  - Methods [1] {+    Method [ <user> public method listen ] {+      @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 30 - 32+    }+  }+}+::listen'

@nicolas-grekas
Copy link
Member

Good catch, thanks@ogizanagi.

@nicolas-grekasnicolas-grekas merged commit61e4592 intosymfony:3.4Nov 11, 2018
nicolas-grekas added a commit that referenced this pull requestNov 11, 2018
…ass usage to describe callables (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#29054   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A`\ReflectionFunctionAbstract::getClosureScopeClass` returns a `\ReflectionClass` instance, not the class name.Before this patch:```diff--- Expected+++ Actual@@ @@-'Symfony\Component\EventDispatcher\Tests\Debug\FooListener::listen'+'Class [ <user> class Symfony\Component\EventDispatcher\Tests\Debug\FooListener ] {+  @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 28-33++  - Constants [0] {+  }++  - Static properties [0] {+  }++  - Static methods [0] {+  }++  - Properties [0] {+  }++  - Methods [1] {+    Method [ <user> public method listen ] {+      @@ [...]/src/Symfony/Component/EventDispatcher/Tests/Debug/WrappedListenerTest.php 30 - 32+    }+  }+}+::listen'```Commits-------61e4592 [Fwb][EventDispatcher][HttpKernel] Fix getClosureScopeClass usage to describe callables
@ogizanagiogizanagi deleted the fix_callable_descr branchNovember 11, 2018 11:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@ogizanagi@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp