Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TwigBridge] Fixed wrong DateTimeType error handling with bootstrap 4 layout#29158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lowwa132 wants to merge1 commit intosymfony:3.4fromlowwa132:ticket_29147

Conversation

@lowwa132
Copy link

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29147
LicenseMIT

Fixed wrong DateTimeType error handling with bootstrap_4_layout.html.twig with (form-control class removed)

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneNov 9, 2018
@nicolas-grekasnicolas-grekas changed the title[TwigBridge] Fix #29147[TwigBridge] Fixed wrong DateTimeType error handling with bootstrap 4 layoutNov 9, 2018
@xabbuh
Copy link
Member

Hm, this was introduced as bugfix in#24802. Maybe@ostrolucky can have a look here.

@ostrolucky
Copy link
Contributor

@lowwa132 Can you post the output of script I posted at#24801 (comment)? This should allow us visual inspection your patch doesn't break anything. This layout has been changed plenty of times since then.

@ostrolucky
Copy link
Contributor

This is wrong.

Before your change:
screenshot_2018-11-24 welcome

After your change:
screenshot_2018-11-24 welcome2

@ostrolucky
Copy link
Contributor

@xabbuh I believe this can be closed as well

@xabbuhxabbuh closed thisDec 4, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@lowwa132@xabbuh@ostrolucky@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp