Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()#29154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromchalasr:cli-bootstrapenv
Nov 10, 2018

Conversation

@chalasr
Copy link
Member

QA
Branch?4.2
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28984,#29126
LicenseMIT
Doc PRtodo

Replaces#29126.

@chalasrchalasr added this to the4.2 milestoneNov 9, 2018
@chalasrchalasr changed the title[Console] Add Application::bootstrapEnv()[Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()Nov 9, 2018
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cool thanks :)

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedNov 9, 2018•
edited
Loading

Two more ideas:

  • add before/after for bin/console in UPGRADE files
  • bump symfony/console to 4.2 (in require-dev and conflict) so that we're sure to get console 4.2 when fwb 4.2 is installed (will make the recipe much simpler)

@chalasr
Copy link
MemberAuthor

@nicolas-grekas updated, thanks

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@chalasrchalasr changed the title[Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()Nov 9, 2018
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, I agree, too opinionated for a component :)

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedNov 10, 2018•
edited
Loading

I'm merging quickly so that the recipes work with 4.2 (they're broken for now.)
It will allow us to play with the new experience more easily to ensure 4.2 will be smooth.
If you have more comments here, please do post them and I'll ensure they're resolved asap.

@nicolas-grekas
Copy link
Member

Thank you@chalasr.

@nicolas-grekasnicolas-grekas merged commitbbd5682 intosymfony:masterNov 10, 2018
nicolas-grekas added a commit that referenced this pull requestNov 10, 2018
…pplication::bootstrapEnv() (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28984,#29126| License       | MIT| Doc PR        | todoReplaces#29126.Commits-------bbd5682 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()
@chalasrchalasr deleted the cli-bootstrapenv branchNovember 10, 2018 11:03
@fmata
Copy link
Contributor

I fixed a minor doc issue + removed\count() calls in#29164.

nicolas-grekas added a commit that referenced this pull requestNov 10, 2018
…ks (fmata)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] Application::bootstrapEnv() minor tweaks| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITJust 2 minor tweaks to#29154 caught while reviewing.Commits-------4e92e6e [FrameworkBundle] Application::bootstrapEnv() upgrade doc fix
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestNov 12, 2018
…from argv via Application::bootstrapEnv() (chalasr)"This reverts commit9253199, reversingchanges made to664a032.
nicolas-grekas added a commit that referenced this pull requestNov 13, 2018
…BUG from argv via Application::bootstrapEnv() (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------Revert "bug#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()This reverts commit9253199, reversingchanges made to664a032.| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Replaced bysymfony/recipes#491, see description there.Commits-------f3c5fda Revert "bug#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() (chalasr)"
@fabpotfabpot mentioned this pull requestNov 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@nicolas-grekas@fmata@ro0NL@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp