Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Unset key during normalization#29152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ro0NL commentedNov 9, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
aiming for 2.8.. i cant imagine ppl rely on UnsetKeyException to be thrown (and handle it themselves) |
nicolas-grekas approved these changesNov 9, 2018
ogizanagi approved these changesNov 10, 2018
fabpot approved these changesNov 12, 2018
Member
fabpot commentedNov 12, 2018
Thank you@ro0NL. |
fabpot added a commit that referenced this pull requestNov 12, 2018
This PR was squashed before being merged into the 2.8 branch (closes#29152).Discussion----------[Config] Unset key during normalization| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes-ish| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#29142| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->2.8 vs. 4.x :) let me know.Commits-------e1402d4 [Config] Unset key during normalization
Merged
This was referencedNov 26, 2018
Merged
Merged
Merged
This was referencedMar 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.8 vs. 4.x :) let me know.