Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow][FrameworkBundle] fixed guard event names for transitions#29137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3c03f3c to32b68cfCompare8a396ba to2b46fc9Comparesrc/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
2b46fc9 to60f95deComparesrc/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
60f95de tobb50dc1Comparesrc/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
bb50dc1 to83dc473Comparenicolas-grekas approved these changesNov 8, 2018
MemberAuthor
lyrixx commentedNov 13, 2018
Thank you@destillat. |
lyrixx added a commit that referenced this pull requestNov 13, 2018
…ansitions (destillat, lyrixx)This PR was merged into the 3.4 branch.Discussion----------[Workflow][FrameworkBundle] fixed guard event names for transitions| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28018#28007 (comment)| License | MIT| Doc PR |There is a bug when many transitions are defined with the same name.I finished destillat's work and rebase against 3.4 as it's a bug fix.There another point of failure, but it could not be fixed on 3.4. I willbe a need feature. The issue is related to `Workflow::can($subject, $transitionName)`.Since the transitionName could be not unique, we will need to supportpassing an instance of Transition. A new PR is incommingCommits-------83dc473 [FrameworkBundle] fixed guard event names for transitionsfb88bfc [FrameworkBundle] fixed guard event names for transitions
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug when many transitions are defined with the same name.
I finished destillat's work and rebase against 3.4 as it's a bug fix.
There another point of failure, but it could not be fixed on 3.4. I will
be a need feature. The issue is related to
Workflow::can($subject, $transitionName).Since the transitionName could be not unique, we will need to support
passing an instance of Transition. A new PR is incomming