Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS#29131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
ro0NL commentedNov 8, 2018
see also |
MemberAuthor
nicolas-grekas commentedNov 8, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
the commands don't care about thread safety: they never run in an IIS thread. |
stof approved these changesNov 8, 2018
chalasr approved these changesNov 8, 2018
dunglas approved these changesNov 8, 2018
nicolas-grekas added a commit that referenced this pull requestNov 8, 2018
…colas-grekas)This PR was merged into the 3.4 branch.Discussion----------[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Since using it is not thread safe, let's not rely on it (already done in other places.)Commits-------21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
Merged
fabpot added a commit that referenced this pull requestAug 30, 2019
…(brentybh)This PR was squashed before being merged into the 4.3 branch (closes#33357).Discussion----------[FrameworkBundle] Fix about command not showing .env varsBefore this fix, `bin/console about` can't properly show `Environment (.env)` section because:`SYMFONY_DOTENV_VARS` which stores all keys of Dotenv-set env vars, is being fetched via `getenv()`.However, in Symfony Dotenv 4.3, usage of `putenv()` is deprecated:symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334so we can get env vars via `getenv()` only when `new Dotenv(true)`.In the default shipped `config/bootstrap.php`, there is `new Dotenv(false)` set.(Maybe related#29131)| Q | A| ------------- | ---| Branch? | 4.3 for bug fixes <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| License | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------f48f19d [FrameworkBundle] Fix about command not showing .env vars
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since using it is not thread safe, let's not rely on it (already done in other places.)