Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options#29126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@chalasr
Copy link
Member

QA
Branch?4.2
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28984
LicenseMIT
Doc PRtodo

Kocal and dmaicher reacted with thumbs up emoji
nicolas-grekas
nicolas-grekas previously approved these changesNov 7, 2018
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedNov 8, 2018•
edited
Loading

I have a new proposal here: let's keep the deprecation in place!
But let's provide an alternative: a new static methodConsole\Application::bootstrapEnv(), whose implementation and signature is the one shipped inhttps://github.com/symfony/recipes/pull/481/files#diff-7da44e840dfd19bb3d28a45e510e8d50R64 (then, deprecation messages should be updated to suggest the alternative)

dunglas, chalasr, ogizanagi, and Tobion reacted with thumbs up emoji

@chalasr
Copy link
MemberAuthor

Closing in favor of#29154.

@chalasrchalasr closed thisNov 9, 2018
@chalasrchalasr deleted the revert-env-deprecation branchNovember 9, 2018 13:04
nicolas-grekas added a commit that referenced this pull requestNov 10, 2018
…pplication::bootstrapEnv() (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28984,#29126| License       | MIT| Doc PR        | todoReplaces#29126.Commits-------bbd5682 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()
nicolas-grekas added a commit that referenced this pull requestNov 14, 2018
…-env and --no-debug console options (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console optionsThis reverts commit9f60ff8.This reverts commit31b5615.| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28984| License       | MIT| Doc PR        | -Working on recipes with@weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.Same as#29126, reverts#28745 and#28653Commits-------443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp