Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] require the needed symfony/contracts package#29095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedNov 5, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29086 |
| License | MIT |
| Doc PR |
nicolas-grekas commentedNov 5, 2018
Shouldn't this be added to the bundle instead? The bridge doesn't force using the TranslationExtension - the bundle does. WDYT? |
xabbuh commentedNov 5, 2018
My reasoning would be that the extension was usable without installing any other package before and would now also break other potential consumers of it that do not use the bundle. |
nicolas-grekas commentedNov 5, 2018
symfony/translation was required, isn't it? and this one links to symfony/contracts in 4.2 |
xabbuh commentedNov 5, 2018
we used |
ro0NL commentedNov 5, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
yes, twig bridge suggests: IIUC the issues is wedont have edit:@xabbuh was faster :) |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
understood, thanks
nicolas-grekas commentedNov 6, 2018
Thank you@xabbuh. |
…(xabbuh)This PR was merged into the 4.2-dev branch.Discussion----------[TwigBridge] require the needed symfony/contracts package| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#29086| License | MIT| Doc PR |Commits-------4400776 require the needed symfony/contracts package