Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TwigBridge] require the needed symfony/contracts package#29095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromxabbuh:issue-29086
Nov 6, 2018

Conversation

@xabbuh
Copy link
Member

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29086
LicenseMIT
Doc PR

@nicolas-grekas
Copy link
Member

Shouldn't this be added to the bundle instead? The bridge doesn't force using the TranslationExtension - the bundle does. WDYT?

@xabbuh
Copy link
MemberAuthor

My reasoning would be that the extension was usable without installing any other package before and would now also break other potential consumers of it that do not use the bundle.

derrabus reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

My reasoning would be that the extension was usable without installing any other package

symfony/translation was required, isn't it? and this one links to symfony/contracts in 4.2

@xabbuh
Copy link
MemberAuthor

@ro0NL
Copy link
Contributor

ro0NL commentedNov 5, 2018
edited
Loading

yes, twig bridge suggests:"symfony/translation": "For using the TranslationExtension".

IIUC the issues is wedont havesymfony/translation and it fallbacks to the contract implementation.. but that's still a soft-dependency 🤔

edit:@xabbuh was faster :)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

understood, thanks

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit4400776 intosymfony:masterNov 6, 2018
nicolas-grekas added a commit that referenced this pull requestNov 6, 2018
…(xabbuh)This PR was merged into the 4.2-dev branch.Discussion----------[TwigBridge] require the needed symfony/contracts package| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29086| License       | MIT| Doc PR        |Commits-------4400776 require the needed symfony/contracts package
@xabbuhxabbuh deleted the issue-29086 branchNovember 6, 2018 16:02
@fabpotfabpot mentioned this pull requestNov 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh@nicolas-grekas@ro0NL@OskarStark@derrabus@ogizanagi@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp