NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Allow null values when denormalizing with constructor missing data#29076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dunglas merged 1 commit intosymfony:4.1fromdanut007ro:denormalizer_null

Nov 8, 2018

Merged

[Serializer] Allow null values when denormalizing with constructor missing data#29076

dunglas merged 1 commit intosymfony:4.1fromdanut007ro:denormalizer_null

Nov 8, 2018

Conversation

Copy link

Contributor

danut007ro commentedNov 4, 2018

Q	A
Branch?	4.1
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT

When usingdefault_constructor_arguments to denormalize objects,null values for a parameter weren't processed, so instantiating was failing.

carsonbot added Status: Needs Review Bug labels

Nov 4, 2018

ogizanagi reviewed

Nov 5, 2018

View reviewed changes

src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php OutdatedShow resolvedHide resolved

nicolas-grekas added this to the4.1 milestone

Nov 6, 2018

nicolas-grekas approved these changes

Nov 6, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 6, 2018

nicolas-grekas changed the title~~Allow null values when denormalizing with constructor missing data~~[Serializer] Allow null values when denormalizing with constructor missing data

Nov 6, 2018

ogizanagi approved these changes

Nov 6, 2018

View reviewed changes

fbourigault approved these changes

Nov 7, 2018

View reviewed changes

dunglas approved these changes

Nov 8, 2018

View reviewed changes

[Serializer] Allow null values when denormalizing with constructor mi…

5fd0f3f

…ssing data

dunglas force-pushed thedenormalizer_null branch fromd63d8e3 to5fd0f3fCompare

November 8, 2018 21:02

Copy link

Member

dunglas commentedNov 8, 2018

Thanks@danut007ro.

dunglas merged commit5fd0f3f intosymfony:4.1

Nov 8, 2018

dunglas added a commit that referenced this pull request

Nov 8, 2018

bug#29076[Serializer] Allow null values when denormalizing with con…

ca5b64d

…structor missing data (danut007ro)This PR was squashed before being merged into the 4.1 branch (closes#29076).Discussion----------[Serializer] Allow null values when denormalizing with constructor missing data| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITWhen using `default_constructor_arguments` to denormalize objects, `null` values for a parameter weren't processed, so instantiating was failing.Commits-------5fd0f3f [Serializer] Allow null values when denormalizing with constructor missing data