Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"#29047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesOct 31, 2018
chalasr approved these changesOct 31, 2018
nicolas-grekas approved these changesOct 31, 2018
nicolas-grekas approved these changesOct 31, 2018
2 tasks
Member
nicolas-grekas commentedNov 1, 2018
Thank you@Tobion. |
nicolas-grekas added a commit that referenced this pull requestNov 1, 2018
…ethod for Request" (Tobion)This PR was merged into the 4.2-dev branch.Discussion----------Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"This reverts commit8a127ea.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#26486| License | MIT| Doc PR |As I said in#26486 (comment) and people wonder inhttps://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core.I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of `*/*` and this is what people usually need in REST APIs etc.But for now, we should revert it before it gets released like this.Commits-------397ed83 Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestNov 11, 2018
…eptableFormat… (kunicmarko20)This PR was merged into the master branch.Discussion----------Revert "minor#9898 [HttpFoundation] Add info for getAcceptableFormat…This reverts commitfbca6db, because it was reverted in the coresymfony/symfony#29047.closes#10656Commits-------27967c2 Revert "minor#9898 [HttpFoundation] Add info for getAcceptableFormats() method (AndreiIgna)"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit8a127ea.
As I said in#26486 (comment) and people wonder inhttps://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core.
I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of
*/*and this is what people usually need in REST APIs etc.But for now, we should revert it before it gets released like this.