Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger][FrameworkBundle] Fix bus name on traceable middleware#29038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ogizanagi wants to merge1 commit intosymfony:masterfromogizanagi:fix/messenger/traceable_midd_bus_name
Closed

[Messenger][FrameworkBundle] Fix bus name on traceable middleware#29038

ogizanagi wants to merge1 commit intosymfony:masterfromogizanagi:fix/messenger/traceable_midd_bus_name

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedOct 31, 2018•
edited
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29034
LicenseMIT
Doc PRN/A

Supersedes#29034.

bin/console debug:container query_bus.middleware.traceable --show-argumentsInformationfor Service"query_bus.middleware.traceable"======================================================== ---------------- ------------------------------------------------------------   Option           Value                                                        ---------------- ------------------------------------------------------------   Service ID       query_bus.middleware.traceable                                Class            Symfony\Component\Messenger\Middleware\TraceableMiddleware                                                      Arguments        query_bus                                                                      Service(debug.stopwatch)                                     ---------------- ------------------------------------------------------------

@nicolas-grekas
Copy link
Member

👎 let's kill these workarounds on top of hacks. We need to play by the rules of the definition inheritance, not against.

@sroze
Copy link
Contributor

Agree with, 👎 I feel it's a bigger hack that the other alternative. 😄

@nicolas-grekas
Copy link
Member

Already fixed by#29010 (comment)
Removing code instead of adding more is a better way to fix things ;)

@sroze
Copy link
Contributor

No it's not, unless you changed things since yesterday evening 🤔

@nicolas-grekas
Copy link
Member

I did, see linked comment ;)

sroze reacted with laugh emoji

@srozesroze closed thisOct 31, 2018
@ogizanagiogizanagi deleted the fix/messenger/traceable_midd_bus_name branchOctober 31, 2018 08:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@nicolas-grekas@sroze@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp