NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fix wrong loop in Process::wait() method#29021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Nek- wants to merge1 commit intosymfony:masterfromNek-:fix/wrong-loop-on-wait-for-process

Closed

Fix wrong loop in Process::wait() method#29021

Nek- wants to merge1 commit intosymfony:masterfromNek-:fix/wrong-loop-on-wait-for-process

Conversation

Copy link

Contributor

Nek- commentedOct 29, 2018

The while condition was the opposite of the previous while. This was obviously leading to the death of this loop. Loop which was useful according to some people (see#28940), so I just moved the code to the right position.

Q	A
Branch?	2.8 (want me to make it against 2.8 ?)
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT

I tested some process execution in order to be sure the code is never executed. I also noticed that there's no CPU issue without this sleep (kubuntu 18.04 / intel i7 2k):

carsonbot added Status: Needs Review Bug labels

Oct 29, 2018

Fix wrong loop in Process::wait() method

b038eb2

The while condition was the opposite of the previous while.This was obviously leading to the death of this loop. Loop whichwas useful according to some people (seesymfony#28940), so I just movedthe code to the right position.