Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] make debug:autowiring list useful services and their description#28970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cfe8e04 tob44a7f4CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bcd423f to2fb426fCompare| * @param string $class | ||
| * | ||
| * @return string | ||
| * @internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the whole sub-namespace is internal, can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks, removed
2fb426f to56aab09Compare…rvices and their description (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] make debug:autowiring list useful services and their description| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27207| License | MIT| Doc PR | -This PRcloses#27207: we don't need "semantics" anymore. 4.2 has everything already to allow us to separate useful services from the other ones: any autowireable *alias* **is** a useful service!Add autowiring by type + parameter name (#28234) and the story is done: we can easily hint people about which features their bundles provide, without being polluted by for-wiring-only services.Here is a screenshot running this command(before I excluded the aliases for $cacheApp and $cacheSystem):ping@weaverryan as we drafted that together.Fixes a few issues found meanwhile.That should definitely go in 4.2.Commits-------56aab09 [FrameworkBundle] make debug:autowiring list useful services and their description
This PRcloses#27207: we don't need "semantics" anymore. 4.2 has everything already to allow us to separate useful services from the other ones: any autowireablealiasis a useful service!
Add autowiring by type + parameter name (#28234) and the story is done: we can easily hint people about which features their bundles provide, without being polluted by for-wiring-only services.
Here is a screenshot running this command(before I excluded the aliases for $cacheApp and $cacheSystem):
ping@weaverryan as we drafted that together.
Fixes a few issues found meanwhile.
That should definitely go in 4.2.