Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] deprecate using invalid names for buttons#28969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedOct 24, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #28964 |
| License | MIT |
| Doc PR |
21c1170 tob9cd039CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| $this->name =$name; | ||
| $this->options =$options; | ||
| if (\preg_match('/^([^a-z0-9_].*)?(.*[^a-zA-Z0-9_\-:].*)?$/D',$name,$matches)) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just asking: is this validating the value of thename HTML attribute of<button> elements ... or is this a Symfony thing? I say this because HTML allows for example: as the first character ofname.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It affects both. The internal name is used to generate the HTML attribute value. Buttons will then behave the same as "normal" form types already behave.
8c3fbf4 tob0af2bbCompareMemberAuthor
xabbuh commentedFeb 21, 2019
ping @symfony/deciders :) |
fabpot approved these changesFeb 21, 2019
Member
fabpot commentedFeb 21, 2019
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestFeb 21, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[Form] deprecate using invalid names for buttons| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#28964| License | MIT| Doc PR |Commits-------405aa54 deprecate using invalid names for buttons
Merged
symfony-splitter pushed a commit to symfony/form that referenced this pull requestMay 29, 2019
…eruto)This PR was merged into the 5.0-dev branch.Discussion----------[Form] Throw exception for invalid form buttons name| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Seesymfony/symfony#28969Commits-------6deeaa42ae Validating form buttons name
nicolas-grekas added a commit that referenced this pull requestMay 29, 2019
…eruto)This PR was merged into the 5.0-dev branch.Discussion----------[Form] Throw exception for invalid form buttons name| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -See#28969Commits-------6deeaa4 Validating form buttons name
fabpot added a commit that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Form] Names for buttons should start with lowercase| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AThis fix changes the messages related to the changes in#28969 - the message used to state that names should start with a letter, a digit ... - so I got a confusing message:```Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("Search" given).'```Which made me find the message, look at the regex that was used, and work out that actually it should start with a lowercase letter, and hence this PR - where I assume there is a reason that the name must start with lowercase letters.Commits-------f65524e Names for buttons should start with lowercase
symfony-splitter pushed a commit to symfony/form that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Form] Names for buttons should start with lowercase| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AThis fix changes the messages related to the changes insymfony/symfony#28969 - the message used to state that names should start with a letter, a digit ... - so I got a confusing message:```Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("Search" given).'```Which made me find the message, look at the regex that was used, and work out that actually it should start with a lowercase letter, and hence this PR - where I assume there is a reason that the name must start with lowercase letters.Commits-------f65524e4e0 Names for buttons should start with lowercase
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.