Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session#28960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 23, 2018
Nice. Would it possible to cover this by a test case? |
dbu commentedOct 23, 2018
good point with the tests. did need to move getting the request up... i think its ok to expand on the existing test and make it do a bit more, rather than create a separate test. okay like this? |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK for me, thanks!
fabpot commentedOct 24, 2018
Thank you@dbu. |
…e no session (dbu)This PR was merged into the 4.1 branch.Discussion----------also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session| Q | A| ------------- | ---| Branch? | 4.1 (feature added in this branch)| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This header is not supposed to ever be exposed to clients of the application, but a hack to transfer information within the symfony application. This bugfix makes it so that we also remove the header when no session is started and thus no decision has to be taken whether to overwrite the caching instructions or not.Commits-------28d9f0c also clean away the NO_AUTO_CACHE_CONTROL_HEADER if we have no session
This header is not supposed to ever be exposed to clients of the application, but a hack to transfer information within the symfony application. This bugfix makes it so that we also remove the header when no session is started and thus no decision has to be taken whether to overwrite the caching instructions or not.