Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] remove classifying sub-namespaces in favor of semantic ones#28947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8accff4 to34a8c2dCompared024de9 to1a3c57eCompare1a3c57e to640ccedCompare
ogizanagi left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Completely makes sense to me.
How do you feel with the AmqpExt in theMessenger/Transport ns? Where would live theMemory/KernelTerminateTransport and upcoming transport bridges/implems if any?
| useSymfony\Component\Messenger\Transport\Enhancers\StopWhenMemoryUsageIsExceededReceiver; | ||
| useSymfony\Component\Messenger\Transport\Enhancers\StopWhenMessageCountIsExceededReceiver; | ||
| useSymfony\Component\Messenger\Transport\Enhancers\StopWhenTimeLimitIsReachedReceiver; | ||
| useSymfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- Symfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver+ Symfony\Component\Messenger\Transport\Receiver\StopWhenMemoryUsageIsExceededReceiver
(same for the two ones below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed thanks
nicolas-grekas commentedOct 22, 2018
I think they're OK in their own sub-namespace - same for other future transports - unless they need just one class I suppose. |
640cced to350a20cCompareTobion commentedOct 25, 2018
The suffix Decorator on |
350a20c to9d8a666Comparenicolas-grekas commentedOct 25, 2018
makes sense, removed. |
9d8a666 to16afb5eComparesroze commentedOct 25, 2018
Thank you@nicolas-grekas. |
… of semantic ones (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] remove classifying sub-namespaces in favor of semantic ones| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -While working on the component, I found it hard to discover the meaning of the `Asynchronous` and `Enhancers` sub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics.I'd like to remove them to make the component easier to discover.This PR introduces a few new semantic sub-namespaces instead.From the changelog: * Classes in the `Middleware\Enhancers` sub-namespace have been moved to the `Middleware` one * Classes in the `Asynchronous\Routing` sub-namespace have been moved to the `Transport\Sender\Locator` sub-namespace * The `Asynchronous/Middleware/SendMessageMiddleware` class has been moved to the `Middleware` namespace * `SenderInterface` and `ChainSender` classes have been moved to the `Transport\Sender` sub-namespace * `ReceiverInterface` and its implementations have been moved to the `Transport\Receiver` sub-namespaceCommits-------16afb5e [Messenger] remove classifying sub-namespaces in favor of semantic ones
Uh oh!
There was an error while loading.Please reload this page.
While working on the component, I found it hard to discover the meaning of the
AsynchronousandEnhancerssub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics.I'd like to remove them to make the component easier to discover.
This PR introduces a few new semantic sub-namespaces instead.
From the changelog:
Middleware\Enhancerssub-namespace have been moved to theMiddlewareoneAsynchronous\Routingsub-namespace have been moved to theTransport\Sender\Locatorsub-namespaceAsynchronous/Middleware/SendMessageMiddlewareclass has been moved to theMiddlewarenamespaceSenderInterfaceandChainSenderclasses have been moved to theTransport\Sendersub-namespaceReceiverInterfaceand its implementations have been moved to theTransport\Receiversub-namespace