Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] remove classifying sub-namespaces in favor of semantic ones#28947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sroze merged 1 commit intosymfony:masterfromnicolas-grekas:messenger-no-subns
Oct 25, 2018

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedOct 22, 2018
edited
Loading

QA
Branch?4.2
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

While working on the component, I found it hard to discover the meaning of theAsynchronous andEnhancers sub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics.

I'd like to remove them to make the component easier to discover.
This PR introduces a few new semantic sub-namespaces instead.

From the changelog:

  • Classes in theMiddleware\Enhancers sub-namespace have been moved to theMiddleware one
  • Classes in theAsynchronous\Routing sub-namespace have been moved to theTransport\Sender\Locator sub-namespace
  • TheAsynchronous/Middleware/SendMessageMiddleware class has been moved to theMiddleware namespace
  • SenderInterface andChainSender classes have been moved to theTransport\Sender sub-namespace
  • ReceiverInterface and its implementations have been moved to theTransport\Receiver sub-namespace

onEXHovia, ro0NL, weaverryan, yceruto, and apfelbox reacted with thumbs up emoji
Copy link
Contributor

@ogizanagiogizanagi left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Completely makes sense to me.
How do you feel with the AmqpExt in theMessenger/Transport ns? Where would live theMemory/KernelTerminateTransport and upcoming transport bridges/implems if any?

useSymfony\Component\Messenger\Transport\Enhancers\StopWhenMemoryUsageIsExceededReceiver;
useSymfony\Component\Messenger\Transport\Enhancers\StopWhenMessageCountIsExceededReceiver;
useSymfony\Component\Messenger\Transport\Enhancers\StopWhenTimeLimitIsReachedReceiver;
useSymfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

- Symfony\Component\Messenger\Transport\StopWhenMemoryUsageIsExceededReceiver+ Symfony\Component\Messenger\Transport\Receiver\StopWhenMemoryUsageIsExceededReceiver

(same for the two ones below)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed thanks

@nicolas-grekas
Copy link
MemberAuthor

How do you feel with the AmqpExt

I think they're OK in their own sub-namespace - same for other future transports - unless they need just one class I suppose.

@Tobion
Copy link
Contributor

The suffix Decorator onActivationMiddlewareDecorator is not consistent with the rest. All other decorators don't have this suffix likeTraceableMiddleware

@nicolas-grekas
Copy link
MemberAuthor

The suffix Decorator on ActivationMiddlewareDecorator is not consistent with the rest

makes sense, removed.

@sroze
Copy link
Contributor

Thank you@nicolas-grekas.

@srozesroze merged commit16afb5e intosymfony:masterOct 25, 2018
sroze added a commit that referenced this pull requestOct 25, 2018
… of semantic ones (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] remove classifying sub-namespaces in favor of semantic ones| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -While working on the component, I found it hard to discover the meaning of the `Asynchronous` and `Enhancers` sub-namespaces. Now that I know the component better, I understand they're only classifying namespaces with no specific technical semantics.I'd like to remove them to make the component easier to discover.This PR introduces a few new semantic sub-namespaces instead.From the changelog:  * Classes in the `Middleware\Enhancers` sub-namespace have been moved to the `Middleware` one * Classes in the `Asynchronous\Routing` sub-namespace have been moved to the `Transport\Sender\Locator` sub-namespace * The `Asynchronous/Middleware/SendMessageMiddleware` class has been moved to the `Middleware` namespace * `SenderInterface` and `ChainSender` classes have been moved to the `Transport\Sender` sub-namespace * `ReceiverInterface` and its implementations have been moved to the `Transport\Receiver` sub-namespaceCommits-------16afb5e [Messenger] remove classifying sub-namespaces in favor of semantic ones
@nicolas-grekasnicolas-grekas deleted the messenger-no-subns branchOctober 25, 2018 09:41
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@nicolas-grekas@Tobion@sroze@xabbuh@ogizanagi@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp