Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Replay referer URL#28936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedOct 21, 2018
Thank you@ro0NL. |
This PR was merged into the 4.2-dev branch.Discussion----------[WebProfilerBundle] Replay referer URL| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#26226| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->For non GET/HEAD requests (e.g. POST) that have a referer URL; allow to replay it. And thereby fix the missing navigation piece to get back to your application.DefaultOn hoverCommits-------9020d49 [WebProfilerBundle] Replay referer URL
ostrolucky commentedOct 21, 2018
I really don't like "replay" terminology. It doesn't replay anything, it just goes to link. |
ro0NL commentedOct 21, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ostrolucky it's not "just" a link, it's the referer; the origin of this profile. As we cant replicate the same profile (method is not "safe"), we - the user - "replay" it. That's my reasoning at least ;) My original idea was Of course we can also simply label it @javiereguiluz thoughts? |
ostrolucky commentedOct 21, 2018
Yes, |
fabpot commentedOct 22, 2018
Actually, I agree with@ostrolucky "back to referer URL" sounds much better to me" and more accurate. |
| <ahref="{{profile.url }}">{{profile.url }}</a> | ||
| {%else %} | ||
| {{profile.url }} | ||
| {%setreferer= profile.collector('request').requestheaders.get('referer') %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this code does not handle the case where therequest collector is not registered, while this case was handled previously (see the handling of status code)
This PR was squashed before being merged into the 4.2-dev branch (closes#28953).Discussion----------[WebProfilerBundle] Reword referer link| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28936 (comment),#28936 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Commits-------a5313ab [WebProfilerBundle] Reword referer link
For non GET/HEAD requests (e.g. POST) that have a referer URL; allow to replay it. And thereby fix the missing navigation piece to get back to your application.
Default
On hover