Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] catch errors while converting to db values in data collector#28917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alekitto
Copy link
Contributor

@alekittoalekitto commentedOct 18, 2018•
edited
Loading

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

When the profiler is enabled and collecting doctrine queries data, if a query fails because ofConversionException or another error thrown while resolving parameters, the data collector is also throwing the same error.

This should fix this case. The tests for this case cannot be executed in 5.4 because Doctrine 2.5 fails with a fatal error inDateType.

@alekittoalekitto changed the base branch frommaster to2.8October 18, 2018 16:10
@nicolas-grekasnicolas-grekas added this to the2.8 milestoneOct 20, 2018
@nicolas-grekas
Copy link
Member

Thanks for the PR. Can you have a look at test failures please?

@alekitto
Copy link
ContributorAuthor

I’ve initially sumbitted the PR on a wrong base branch and I changed it later, but the build has not restarted, could you please restart it or should I push another commit to rebuild it?
Another thing: fabbot.io complains about a line that I’ve not touched, should I edit it or leave it as is?

@l-vo
Copy link
Contributor

@alekitto you can simply amend your commit and push it again (git commit --amend && git push -f) :)

@alekittoalekittoforce-pushed thefix-doctrine-data-collector-exception branch 3 times, most recently frome58c5a5 to0187892CompareOctober 22, 2018 21:21
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK for me after the suggested change.

@alekittoalekittoforce-pushed thefix-doctrine-data-collector-exception branch from0187892 to61c4531CompareNovember 24, 2018 17:29
@fabpot
Copy link
Member

Thank you@alekitto.

@fabpotfabpot merged commit61c4531 intosymfony:2.8Nov 26, 2018
fabpot added a commit that referenced this pull requestNov 26, 2018
…s in data collector (alekitto)This PR was merged into the 2.8 branch.Discussion----------[DoctrineBridge] catch errors while converting to db values in data collector| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITWhen the profiler is enabled and collecting doctrine queries data, if a query fails because of `ConversionException` or another error thrown while resolving parameters, the data collector is also throwing the same error.This should fix this case. The tests for this case cannot be executed in 5.4 because Doctrine 2.5 fails with a fatal error in `DateType`.Commits-------61c4531 [DoctrineBridge] catch errors while converting to db values in data collector
@alekittoalekitto deleted the fix-doctrine-data-collector-exception branchNovember 26, 2018 11:14
@xabbuhxabbuh mentioned this pull requestNov 26, 2018
This was referencedNov 26, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

6 participants

@alekitto@nicolas-grekas@l-vo@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp