Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] rename "envelope items" and move them in the "Stamp" namespace#28911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
722354c to74284f6CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
74284f6 to0ad2cb9Compare
ogizanagi left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I <3 all of this! TheStamp is much more understandable to me than the EnvelopeItems. We are now, for example, "stamping the message validation configuration".
…he "Stamp" namespace (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] rename "envelope items" and move them in the "Stamp" namespace| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Right now, envelope items are scattered in different sub namespaces and use the "Configuration" suffix.This makes them hard to discover.This PR creates a new `Stamp` namespace and moves all "envelope items" there, renaming them to use the "stamp" terminology.From the changelog: * `Envelope`'s constructor and `with` method now accept `StampInterface` objects as variadic parameters * Renamed `EnvelopeItemInterface` to `StampInterface` * Renamed and moved `ReceivedMessage`, `ValidationConfiguration` and `SerializerConfiguration` in the `Stamp` namespace * Removed the `WrapIntoReceivedMessage` (it's untested and unused)Commits-------0ad2cb9 [Messenger] rename "envelope items" and move them in the "Stamp" namespace
sroze commentedOct 21, 2018
Oh my god. You hipsters! |
Right now, envelope items are scattered in different sub namespaces and use the "Configuration" suffix.
This makes them hard to discover.
This PR creates a new
Stampnamespace and moves all "envelope items" there, renaming them to use the "stamp" terminology.From the changelog:
Envelope's constructor andwithmethod now acceptStampInterfaceobjects as variadic parametersEnvelopeItemInterfacetoStampInterfaceReceivedMessage,ValidationConfigurationandSerializerConfigurationin theStampnamespaceWrapIntoReceivedMessage(it's untested and unused)