Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Introduce KernelInterface::getProjectDir()#28901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * @method string getProjectDir() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's add a description, eg:@method string getProjectDir() Gets the application root dir (path of the project's composer file) - not defining it is deprecated since Symfony 4.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it works. can you do a github suggestion? Im so curious about that :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done :)
Uh oh!
There was an error while loading.Please reload this page.
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| span class="pl-s1"> * @method string getProjectDir() Gets the project dir (path of the project's composer file) - not defining it is deprecated since Symfony 4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it failed :)
can you squash also please?
fabpot commentedOct 17, 2018
Thank you@ro0NL. |
…(ro0NL)This PR was merged into the 4.2-dev branch.Discussion----------[HttpKernel] Introduce KernelInterface::getProjectDir()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | not yet| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28897 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Removes the last call to getParameter('kernel.project_dir') during runtime in core. Yay :)cc@fabpot@nicolas-grekasCommits-------b046f41 [HttpKernel] Introduce KernelInterface::getProjectDir()
This PR was squashed before being merged into the 4.3-dev branch (closes#28902).Discussion----------[Debug] Detect virtual methods using@method| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28897 (comment)| License | MIT| Doc PR |symfony/symfony-docs#10504My first Debug PR, so im still on it. But early feedback welcome.In#28901 we'll introduce a new virtual interface method using `@method` annotation. IIUC the idea is to trigger whenever such a method is overridden.Commits-------38877c3 [Debug] Detect virtual methods using@method
Removes the last call to getParameter('kernel.project_dir') during runtime in core. Yay :)
cc@fabpot@nicolas-grekas