Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] fix deprecating KernelInterface::getRootDir()#28890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 16, 2018
(ready) |
| $this->fileLinkFormat =$fileLinkFormat ?:ini_get('xdebug.file_link_format') ?:get_cfg_var('xdebug.file_link_format'); | ||
| $this->projectDir =str_replace('\\','/',$projectDir).'/'; | ||
| $this->rootDir =$this->projectDir; | ||
| $this->rootDir =str_replace('\\','/',$projectDir).'/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would keep the new name, it's easier to follow along.
nicolas-grekasOct 16, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but changing it breaks BC...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes and no. That's internal/obsolete code (templating vs Twig).
fabpot commentedOct 16, 2018
Thank you@nicolas-grekas. |
…() (nicolas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[HttpKernel] fix deprecating KernelInterface::getRootDir()| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up of#28810.Did I get it right?Commits-------819f525 [HttpKernel] fix deprecating KernelInterface::getRootDir()
…0NL)This PR was merged into the 4.2-dev branch.Discussion---------- [TwigBridge] Remove $rootDir argument in CodeExtension| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |symfony/symfony-docs#10547 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Forgotten in#28890cc@javiereguiluzCommits-------f894724 [TwigBridge] Remove $rootDir argument in CodeExtension
Follow up of#28810.
Did I get it right?