Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] A test case for stringifying of Process arguments#28864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromvudaltsov:process-argument-escape-testOct 14, 2018
Merged
[Process] A test case for stringifying of Process arguments#28864
nicolas-grekas merged 1 commit intosymfony:3.4fromvudaltsov:process-argument-escape-testOct 14, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedOct 14, 2018
Thank you@vudaltsov. |
nicolas-grekas added a commit that referenced this pull requestOct 14, 2018
…nts (vudaltsov)This PR was merged into the 3.4 branch.Discussion----------[Process] A test case for stringifying of Process arguments| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | for#28863| License | MIT| Doc PR |Checks that non-string arguments passed to Process constructor are typecasted to stringCommits-------0d54342 Add a test case for stringifying of Process arguments
ContributorAuthor
vudaltsov commentedOct 14, 2018
@nicolas-grekas , could you also merge this into 4.1, so that I can rebase and test#28863? |
Member
nicolas-grekas commentedOct 14, 2018
Done |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks that non-string arguments passed to Process constructor are typecasted to string