Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Skip empty proxy code#28861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
olvlvl commentedOct 14, 2018
Looks like there's an issue during the php7.2 build. |
nicolas-grekas commentedOct 14, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Note that while the code may not work correctly when no code is returned, I'm not sure it's legit to return nothing: |
495124d tobaf6f8cComparenicolas-grekas commentedOct 20, 2018
Thank you@olvlvl. |
This PR was merged into the 2.8 branch.Discussion----------[DependencyInjection] Skip empty proxy code| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28852| License | MITFix#28852@nicolas-grekas I'm not sure which branch this should be applied to, please let me know.Commits-------baf6f8c Skip empty proxy code
Fix#28852
@nicolas-grekas I'm not sure which branch this should be applied to, please let me know.