Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Skip empty proxy code#28861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.8fromolvlvl:olvlvl-phpdumper
Oct 20, 2018

Conversation

@olvlvl
Copy link
Contributor

QA
Branch?4.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28852
LicenseMIT

Fix#28852

@nicolas-grekas I'm not sure which branch this should be applied to, please let me know.

@olvlvl
Copy link
ContributorAuthor

Looks like there's an issue during the php7.2 build.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedOct 14, 2018
edited
Loading

Note that while the code may not work correctly when no code is returned, I'm not sure it's legit to return nothing:
looking at your work inhttps://github.com/olvlvl/symfony-dependency-injection-proxy, I see that you generate proxies as anonymous classes. But this means that if the same interface (or set of interfaces) is proxied several times for several different services, the implementation for the proxy is going to be duplicated as many times.
Might be better to consider returning nothing is unsupported and dedup proxies on your side?

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneOct 17, 2018
@nicolas-grekasnicolas-grekas changed the base branch frommaster to2.8October 20, 2018 20:16
@nicolas-grekasnicolas-grekas modified the milestones:3.4,2.8Oct 20, 2018
@nicolas-grekas
Copy link
Member

Thank you@olvlvl.

olvlvl reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitbaf6f8c intosymfony:2.8Oct 20, 2018
nicolas-grekas added a commit that referenced this pull requestOct 20, 2018
This PR was merged into the 2.8 branch.Discussion----------[DependencyInjection] Skip empty proxy code| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28852| License       | MITFix#28852@nicolas-grekas I'm not sure which branch this should be applied to, please let me know.Commits-------baf6f8c Skip empty proxy code
@olvlvlolvlvl deleted the olvlvl-phpdumper branchOctober 22, 2018 08:08
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

3 participants

@olvlvl@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp