Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Deprecate TimezoneType regions option#28860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromro0NL:tz-regions
Oct 25, 2018
Merged

[Form] Deprecate TimezoneType regions option#28860

fabpot merged 1 commit intosymfony:masterfromro0NL:tz-regions
Oct 25, 2018

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedOct 14, 2018
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#28848
LicenseMIT
Doc PRsymfony/symfony-docs#...

I know i've added this option myself in 4.1, but given my recent development for#28624 i realized it's an opinionated feaure, which can/should be solved on user-side (choice_filter/choice_loader and/orgroup_by).

While at it, i solved a few issues withOptionsResolver that is able to deprecate options as of 4.2 also. Fixed in#28878

  • when resolved trigger the deprecation
  • allow to opt-out from triggering the deprecation
  • dont trigger deprecation for default values (only given ones)

@ro0NL
Copy link
ContributorAuthor

to go after#28878

status: needs work

@fabpot
Copy link
Member

#28878 has been merged now

@ro0NL
Copy link
ContributorAuthor

@yceruto a deprecated option doesnt behave correct yet, the opt-out isnt working. Each test triggers still

  15x: The option "regions" is deprecated since Symfony 4.2.    2x in TimezoneTypeTest::testDateTimeZoneInput from Symfony\Component\Form\Tests\Extension\Core\Type

@yceruto
Copy link
Member

@yceruto
Copy link
Member

That should be fixed updating the composer constraint of the FB I guess.

@yceruto
Copy link
Member

@yceruto
Copy link
Member

Fixed in#28968

fabpot added a commit that referenced this pull requestOct 25, 2018
…(yceruto)This PR was merged into the 4.2-dev branch.Discussion----------[OptionsResolver] Fixed explicitly ignores a depreciation| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28860 (comment)| License       | MIT| Doc PR        | -When a deprecated option with default value was resolved (the first time it's called) in this case through a lazy evaluation, [the default resolution process](https://github.com/symfony/symfony/blob/8398947c9c1c1266aad0bea773d0b524e0d81643/src/Symfony/Component/OptionsResolver/OptionsResolver.php#L771-L773) takes the resolved value and here should also trigger only if the option was provided by the user or is being called from a lazy evaluation, otherwise ignore.Commits-------8398947 Fixed explicitly ignores a depreciation
@ro0NL
Copy link
ContributorAuthor

Status: needs review

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit5cb532d intosymfony:masterOct 25, 2018
fabpot added a commit that referenced this pull requestOct 25, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Form] Deprecate TimezoneType regions option| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28848| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->I know i've added this option myself in 4.1, but given my recent development for#28624 i realized it's an opinionated feaure, which can/should be solved on user-side (`choice_filter/choice_loader` and/or `group_by`).- blocks translations as we dont have them (see#28831)- blocks possibility of switching to Intl zones which doesnt really have this filter feature (see#28836)~While at it, i solved a few issues with `OptionsResolver` that is able to deprecate options as of 4.2 also.~ Fixed in#28878- when resolved trigger the deprecation- allow to opt-out from triggering the deprecation- dont trigger deprecation for default values (only given ones)Commits-------5cb532d [Form] Deprecate TimezoneType regions option
@ro0NLro0NL deleted the tz-regions branchOctober 25, 2018 13:25
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestOct 26, 2018
This PR was merged into the master branch.Discussion----------[Form] Deprecated timezone regions optionseesymfony/symfony#28860Commits-------edf7f5d [Form] Deprecated timezone regions option
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@ro0NL@fabpot@yceruto@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp