Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Scroll into view when searching#28854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromro0NL:dump
Oct 27, 2018
Merged

[VarDumper] Scroll into view when searching#28854

fabpot merged 1 commit intosymfony:masterfromro0NL:dump
Oct 27, 2018

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedOct 14, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

This jumps to the found element when using the javascript widget for searching HTML dumps. Inspired by Ctrl+F in Chrome :)

It's super convenient with long dumps, however i wasnt able to position the search input on the right in a fixed manner... because CSS 😓 i was hoping@ogizanagi could add a patch for it.

Also seehttps://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView

@ogizanagi
Copy link
Contributor

Positioning it fixed relative to the mainpre.sf-dump should be easy, but you cannot combine float andposition: fixed. So that means the search bar would be over the content and thus hide part of it instead of "pushing it". It can be tricky for its width too. Both these issues can be annoying in narrow places (like in the profiler) where it's used. So not sure it's worth it, but I'll have a look.

@ro0NL
Copy link
ContributorAuthor

So not sure it's worth it, but I'll have a look.

Maybe using flex display will do? But no blocker for me.. the keyboard shortcuts work either way.

@ogizanagi
Copy link
Contributor

Actually I don't see how using a flex display could help for this :/
The only "working" solution to me is having a toolbar on top of the dump content instead of being inside.

@ro0NL
Copy link
ContributorAuthor

👍 for a fixed top bar, that reduces the possible min. width as well. Let me know if i should have a look in this PR.

@nicolas-grekasnicolas-grekas added this to thenext milestoneOct 14, 2018
@ro0NL
Copy link
ContributorAuthor

friendly ping for 4.2 as-is :)

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit647a937 intosymfony:masterOct 27, 2018
fabpot added a commit that referenced this pull requestOct 27, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[VarDumper] Scroll into view when searching| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This jumps to the found element when using the javascript widget for searching HTML dumps. Inspired by Ctrl+F in Chrome :)It's super convenient with long dumps, however i wasnt able to position the search input on the right in a fixed manner... because CSS 😓 i was hoping@ogizanagi could add a patch for it.Also seehttps://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewCommits-------647a937 [VarDumper] Scroll into view when searching
@ro0NLro0NL deleted the dump branchOctober 27, 2018 16:22
This was referencedNov 3, 2018
@ro0NLro0NL mentioned this pull requestNov 12, 2018
@ro0NLro0NL mentioned this pull requestJan 25, 2019
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes#29984).Discussion----------[VarDumper] Fixed search bar| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Continuation of#28854, replaces#29176initial:![image](https://user-images.githubusercontent.com/1047696/51747953-3c9e1400-20ab-11e9-913d-d60bd59ee2d9.png)ctrl f:![image](https://user-images.githubusercontent.com/1047696/51747973-4b84c680-20ab-11e9-8d07-e6128822fbb2.png)scroll:![image](https://user-images.githubusercontent.com/1047696/51747984-550e2e80-20ab-11e9-8b54-b24109d2280a.png)tested in chrome+ffcc@ogizanagirefhttps://caniuse.com/#feat=css-stickyCommits-------99d2893 [VarDumper] Fixed search bar
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL@ogizanagi@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp