Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[LDAP] Add TIMEOUT Option to LDAP Connection Options#28853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
javiereguiluz commentedNov 7, 2018
@lmatte7 thanks for contributing this (and congrats on your first Symfony contribution!) In order to update the Symfony Docs about LDAP, we'd need to know which changes are required to use this feature:
Thanks a lot! |
lmatte7 commentedNov 7, 2018
@javiereguiluz thanks for the comment, I'm excited about being able to contribute! Looking at the current docs I don't believe this option will need to be added specifically to any page.This page links out to show all of the available connection options, so as long as the option will be listedhere it aligns with the current documentation. As for a default option, I don't see one while looking through the PHP documentation or source code. I don't believe this option has a value until it is manually set by the code, and this aligns with my testing of this issue as well. |
javiereguiluz commentedNov 7, 2018
@lmatte7 great! Thanks a lot for checking the docs. This is much appreciated! |
nicolas-grekas commentedDec 1, 2018
Thank you@lmatte7. |
…te7)This PR was submitted for the master branch but it was squashed and merged into the 4.2 branch instead (closes#28853).Discussion----------[LDAP] Add TIMEOUT Option to LDAP Connection Options| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? |no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This PR adds a TIMEOUT (Full name `LDAP_OPT_TIMEOUT`) option to the `ConnectionOptions.php` class in the LDAP Component. This option is not documented in the PHP Docs for the LDAP component but is required to set a timeout for certain server configurations. One use case for this option is if the LDAP server has a whitelist the client is not approved to access.Commits-------2d88b89 [LDAP] Add TIMEOUT Option to LDAP Connection Options
This PR adds a TIMEOUT (Full name
LDAP_OPT_TIMEOUT) option to theConnectionOptions.phpclass in the LDAP Component. This option is not documented in the PHP Docs for the LDAP component but is required to set a timeout for certain server configurations. One use case for this option is if the LDAP server has a whitelist the client is not approved to access.