Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Intl] Blacklist invalid languages#28833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromro0NL:language
Oct 12, 2018
Merged

[Intl] Blacklist invalid languages#28833

fabpot merged 1 commit intosymfony:masterfromro0NL:language
Oct 12, 2018

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedOct 12, 2018
edited
Loading

QA
Branch?master
Bug fix?yes?
New feature?yes?
BC breaks?no?
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

seehttps://en.wikipedia.org/wiki/ISO_639-3#Special_codes

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedOct 12, 2018
edited
Loading

i tend to add a changelog note and go with master.. let me know.

edit: done

@ro0NL
Copy link
ContributorAuthor

for consistency, we could apply the same for scripts. E.g.Zzzz is an "unknown script" code... but i've never really worked with scripts, so i dont mind. But let me know :) i think it wouldnt hurt.

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commit4f5404b intosymfony:masterOct 12, 2018
fabpot added a commit that referenced this pull requestOct 12, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Intl] Blacklist invalid languages| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes?| New feature?  | yes?| BC breaks?    | no?| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->seehttps://en.wikipedia.org/wiki/ISO_639-3#Special_codesCommits-------4f5404b [Intl] Blacklist invalid languages
@ro0NLro0NL deleted the language branchOctober 12, 2018 16:06
This was referencedNov 3, 2018
@ro0NLro0NL mentioned this pull requestMar 16, 2019
fabpot added a commit that referenced this pull requestMar 17, 2019
This PR was merged into the 3.4 branch.Discussion----------[Intl] Add compile binary| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no-ish| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from#28831)```bash$ src/Symfony/Component/Intl/Resources/bin/compile```run in repository root because ofhttps://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L1413.4 is ok, 4.2 is not because of#28833 but new locales are introduced inhttps://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :))Commits-------426b92f [Intl] Add compile binary
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp