Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Blacklist invalid languages#28833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedOct 12, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
i tend to add a changelog note and go with master.. let me know. edit: done |
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedOct 12, 2018
for consistency, we could apply the same for scripts. E.g. |
fabpot commentedOct 12, 2018
Thank you@ro0NL. |
This PR was merged into the 4.2-dev branch.Discussion----------[Intl] Blacklist invalid languages| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes?| New feature? | yes?| BC breaks? | no?| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->seehttps://en.wikipedia.org/wiki/ISO_639-3#Special_codesCommits-------4f5404b [Intl] Blacklist invalid languages
This PR was merged into the 3.4 branch.Discussion----------[Intl] Add compile binary| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no-ish| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from#28831)```bash$ src/Symfony/Component/Intl/Resources/bin/compile```run in repository root because ofhttps://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L1413.4 is ok, 4.2 is not because of#28833 but new locales are introduced inhttps://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :))Commits-------426b92f [Intl] Add compile binary
Uh oh!
There was an error while loading.Please reload this page.
seehttps://en.wikipedia.org/wiki/ISO_639-3#Special_codes