NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder'#28830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfrommcsky:fix/yaml-encoder-constant-visibility

Oct 12, 2018

Merged

'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder'#28830

fabpot merged 1 commit intosymfony:masterfrommcsky:fix/yaml-encoder-constant-visibility

Oct 12, 2018

Conversation

Copy link

mcsky commentedOct 12, 2018•
edited
Loading

A little fix of myprevious PR

This PR changes the constant visibility of theyml format as private.

Because as@stof mentionnedyml isn't a format, so the constant shoudn't be public.

Otherwise, this will be confusing while using autocomplete, you see two formats. The user can ask himself if there is a difference betweenyaml /yml.

No need of that :)

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	-
License	MIT
Doc PR

'yml' is not a format and shouldn't be visible as constant from 'Yaml…

674b359

…Encoder' class

carsonbot added Status: Needs Review and removed Status: Needs Review labels

Oct 12, 2018

ro0NL approved these changes

Oct 12, 2018

View reviewed changes

carsonbot added the Status: Reviewed label

Oct 12, 2018

fabpot approved these changes

Oct 12, 2018

View reviewed changes

Copy link

Member

fabpot commentedOct 12, 2018

Thank you@mcsky.

fabpot merged commit674b359 intosymfony:master

Oct 12, 2018

fabpot added a commit that referenced this pull request

Oct 12, 2018

minor#28830'yml' is not a format and shouldn't be visible as consta…

261c0de

…nt from 'YamlEncoder' (kevin-biig)This PR was merged into the 4.2-dev branch.Discussion----------'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder'A little fix of my [previous PR](#28815)This PR changes the constant visibility of the `yml` format as private.Because as@stof [mentionned](#28815 (comment)) `yml` isn't a format, so the constant  shoudn't be public.Otherwise, this will be confusing while using autocomplete, you see two formats. The user can ask himself if there is a difference between `yaml` / `yml`.No need of that :)| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Fixed tickets | -| License       | MIT| Doc PR        |Commits-------674b359 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' class