NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Dotenv] Class should be case sensitive#28826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromseriquynh:class_should_be_case_sensitive

Oct 12, 2018

Merged

[Dotenv] Class should be case sensitive#28826

fabpot merged 1 commit intosymfony:3.4fromseriquynh:class_should_be_case_sensitive

Oct 12, 2018

Conversation

Copy link

Contributor

seriquynh commentedOct 12, 2018

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

PHP 5.6 - 7.x allows to use case-insensitive with class's name but should we do?

namespaceExample;class Application{}var_dump(class_exists(\Example\ApPlIcAtIoN::class));// truevar_dump(class_exists(\Example\APPLICATION::class));// true

carsonbot added Status: Needs Review Status: Reviewed and removed Status: Needs Review labels

Oct 12, 2018

OskarStark approved these changes

Oct 12, 2018

View reviewed changes

javiereguiluz approved these changes

Oct 12, 2018

View reviewed changes

xabbuh approved these changes

Oct 12, 2018

View reviewed changes

xabbuh added this to the3.4 milestone

Oct 12, 2018

fabpot approved these changes

Oct 12, 2018

View reviewed changes

Class should be case sensitive

6a0ab51

fabpot changed the base branch frommaster to3.4

October 12, 2018 12:54

Copy link

Member

fabpot commentedOct 12, 2018

Thank you@XuanQuynh.

fabpot merged commit6a0ab51 intosymfony:3.4

Oct 12, 2018

fabpot added a commit that referenced this pull request

Oct 12, 2018

minor#28826[Dotenv] Class should be case sensitive (xuanquynh)

ec32d43

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes#28826).Discussion----------[Dotenv] Class should be case sensitive| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |PHP 5.6 - 7.x allows to use case-insensitive with class's name but should we do?```phpnamespace Example;class Application{}var_dump(class_exists(\Example\ApPlIcAtIoN::class)); // truevar_dump(class_exists(\Example\APPLICATION::class)); // true```Commits-------6a0ab51 Class should be case sensitive