Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Fix tags on multiple decorated service#28820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromshyim:decoration-and-tags
Oct 31, 2018
Merged

[DependencyInjection] Fix tags on multiple decorated service#28820

nicolas-grekas merged 1 commit intosymfony:3.4fromshyim:decoration-and-tags
Oct 31, 2018

Conversation

@shyim
Copy link
Contributor

@shyimshyim commentedOct 11, 2018•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28682
LicenseMIT
Doc PR

After the first run in the loop with the same decorated service it goes only in the hasAlias condition. The tags will be not set here, so theResolveTaggedIteratorArgumentPass will handle only the first decoration.

teiling88, Crease29, mnaczenski, MarcelSchmaeing, jkrzefski, t2oh4e, and Christian-Rades reacted with thumbs up emojiteiling88, mitelg, Crease29, jkrzefski, and t2oh4e reacted with hooray emoji
@nicolas-grekas
Copy link
Member

Thanks for working on this! Could you add a test case please?

@shyim
Copy link
ContributorAuthor

I have added a Test which fails, without the Changes.

teiling88, jochenmanz, and PascalThesing reacted with thumbs up emojiteiling88 reacted with hooray emoji

@nicolas-grekas
Copy link
Member

FYI I pushed-forced an alternative implementation that more precisely focuses on fixing multiple decorations while taking care of not changing the semantics of decorating unrelated aliases.
Ready on my side.

@shyim
Copy link
ContributorAuthor

Looks fine for me 😊

@nicolas-grekas
Copy link
Member

Thank you@shyim.

shyim reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commit90f8df2 intosymfony:3.4Oct 31, 2018
nicolas-grekas added a commit that referenced this pull requestOct 31, 2018
…ce (Soner Sayakci)This PR was merged into the 3.4 branch.Discussion----------[DependencyInjection] Fix tags on multiple decorated service| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28682| License       | MIT| Doc PR        |After the first run in the loop with the same decorated service it goes only in the hasAlias condition. The tags will be not set here, so the `ResolveTaggedIteratorArgumentPass` will handle only the first decoration.Commits-------90f8df2 [DependencyInjection] Fix tags on multiple decorated service
@shyimshyim deleted the decoration-and-tags branchOctober 31, 2018 10:54
This was referencedNov 3, 2018
@shyimshyim mentioned this pull requestFeb 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@shyim@nicolas-grekas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp