Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Finder] make reverse sorting a bit more generic#28802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 10, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27967 (comment) |
| License | MIT |
| Doc PR | - |
2cd108a toce861d1Comparefabpot commentedOct 10, 2018
Thank you@nicolas-grekas. |
…s-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[Finder] make reverse sorting a bit more generic| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27967 (comment)| License | MIT| Doc PR | -Commits-------ce861d1 [Finder] make reverse sorting a bit more generic
| * | ||
| * @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
| */ | ||
| class ReverseSortingIteratorimplements \IteratorAggregate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this class should be deprecated, not removed, as it was not marked internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This class only exists in master (as the PR was merged a few hours ago only).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm indeed, I missed that
| }; | ||
| }elseif (self::SORT_BY_NONE ===$sort) { | ||
| $this->sort =$order; | ||
| }elseif (\is_callable($sort)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what about order support for this case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed in4d70a0b