Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
invalidate stale commits for PRs too#28788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 9, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| } | ||
| if (!$referencedCommits || (isset($_SERVER['TRAVIS_PULL_REQUEST']) &&'false' !==$_SERVER['TRAVIS_PULL_REQUEST'])) { | ||
| // cached commits cannot be stale for PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it seems they can:https://travis-ci.org/symfony/symfony/jobs/438809475
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's good: now than we use flex as an accelerator, this is not really slow anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks
fabpot commentedOct 10, 2018
Thank you@xabbuh. |
This PR was merged into the 2.8 branch.Discussion----------invalidate stale commits for PRs too| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------aee63f5 invalidate stale commits for PRs too
xabbuh commentedOct 10, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas Can you please check this change nonetheless? It makes build pass again, but I am not fully sure that I did not break any legitimate use case (i.e. maybe we now invalidate too often and thus slowing builds down again). |