Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[CS] Enable phpdoc_types_order#28780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| 'self_accessor' =>false, | ||
| // Part of @Symfony:risky in PHP-CS-Fixer 2.13.0. To be removed from the config file once upgrading | ||
| 'native_function_invocation' =>array('include' =>array('@compiler_optimized'),'scope' =>'namespaced'), | ||
| 'phpdoc_types_order' =>array('null_adjustment' =>'always_last','sort_algorithm' =>'none'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note that the comment above is misleading: the rule isn't part of any ruleset for now. Do you mind submitting a PR on PHP CS Fixer to update theSymfony ruleset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@julienfalque What branch in PHP-CS-Fixer should I send? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rulesets updates are done on minor releases so you should target branch master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@julienfalque Cool. Gonna update the comment here for now, as well, submit a patch for the ruleset in php-cs-fixer 😊
fabpot commentedOct 11, 2018
Thank you@carusogabriel. |
This PR was merged into the 2.8 branch.Discussion----------[CS] Enable phpdoc_types_order| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | - <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | -As suggested by@jvasseur in#28675 (comment), we can use the `phpdoc_types_order` rule from PHP-CS-Fixer to ensure that `null` is always on the last position in phpDocs as proposed in#28675.Commits-------c340502 [CS] Enable phpdoc_types_order
…abriel)This PR was merged into the 2.14-dev branch.Discussion----------Add phpdoc_types_order rule to Symfony's rulesetAs suggested by@julienfalque insymfony/symfony#28780, besides add this new rule due tosymfony/symfony#28675, we should also enforces it in Symfony's ruleset here too 😊Commits-------c2ccec2 Add phpdoc_types_order rule to Symfony's ruleset
This PR was merged into the 2.8 branch.Discussion----------[standards] Document "phpdoc_types_order"Seesymfony/symfony#28780.Commits-------7587534 [standards] Document "phpdoc_types_order"
As suggested by@jvasseur in#28675 (comment), we can use the
phpdoc_types_orderrule from PHP-CS-Fixer to ensure thatnullis always on the last position in phpDocs as proposed in#28675.