Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] deal with explicitly enabled workflow nodes#28769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 8, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | #28662 |
| License | MIT |
| Doc PR |
| http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"> | ||
| <framework:config> | ||
| <framework:workflow enabled="true" name="foo" type="workflow" initial-place="bar"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test currently does not pass. For the other formats the attribute is not configured per workflow but only once. How do we want to handle it in XML? Completely forbidding it? Requiring it to have the same value for each workflow if the attribute is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@symfony/deciders What is your opinion here? :)
nicolas-grekasOct 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
actually what's the meaning of the "enabled" option on the configuration?
as soon as one workflow is defined, workflow is enabled - and if no workflows are defined, it's disabled.
Wouldn't this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Generally yes, this option was introduced to be able to explicitly enable the workflow services while not using the config to define your workflows (see#24051 for the context).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
XML are boring for the framework configuration.
I would like instead close#28662 as won't fix. Use should use the "regular" way to define workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Anyway, I would go for supporting<framework:workflow enabled="true" />
or your current exemple withoutenabled="true"
and that's all
xabbuh commentedNov 16, 2018
The extension now throws when Status: Needs Review |
lyrixx commentedNov 19, 2018
... and one more bug fixed, thank you Christian. |
…des (xabbuh)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] deal with explicitly enabled workflow nodes| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | not yet| Fixed tickets |#28662| License | MIT| Doc PR |Commits-------017fd56 deal with explicitly enabled workflow nodes