Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] fix dumping inline services again#28760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $b->foo = $instance; | ||
| $a->bar = $b; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't we set this property earlier, to have the property set at the time ofnew \App\Foo($a) ?
nicolas-grekasOct 9, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's important to set deps as late as possible, so that the consumer see them as populated as possible. The reason is that code usually expect it this way. The typical exemple is doctrine's configuration object, which must be fully defined before injection, so that consumers can use it immediately.
This PR was merged into the 3.4 branch.Discussion----------[DI] fix dumping inline services again| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28720#28710| License | MIT| Doc PR | -The main fix is in `PhpDumper::addInlineService()`Fixes a few other glitches found meanwhile.Commits-------a854b0a [DI] fix dumping inline services again
The main fix is in
PhpDumper::addInlineService()Fixes a few other glitches found meanwhile.