Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] minor optim for dumped container#28753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
ostrolucky commentedOct 7, 2018
Why does it even need a closure, instead of callable in the first place? |
MemberAuthor
nicolas-grekas commentedOct 7, 2018
Because the method is private so it cannot be exported. |
ostrolucky approved these changesOct 7, 2018
azjezz approved these changesOct 7, 2018
javiereguiluz approved these changesOct 8, 2018
chalasr approved these changesOct 8, 2018
fabpot approved these changesOct 10, 2018
Member
fabpot commentedOct 10, 2018
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestOct 10, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[DI] minor optim for dumped container| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Spotted while reviewing a real-world dumped container.Commits-------c1863e3 [DI] minor optim for dumped container
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while reviewing a real-world dumped container.