Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebServerBundle] Deprecate relying on --env in server:start and server:run#28745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
chalasr commentedOct 5, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
fabpot approved these changesOct 6, 2018
Member
fabpot commentedOct 6, 2018
Thank you@chalasr. |
fabpot added a commit that referenced this pull requestOct 6, 2018
…:start and server:run (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[WebServerBundle] Deprecate relying on --env in server:start and server:run| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aCommits-------31b5615 [WebServerBundle] Deprecate relying on --env in server:start and server:run
Member
nicolas-grekas commentedNov 13, 2018
Reverted in#29204 |
nicolas-grekas added a commit that referenced this pull requestNov 14, 2018
…-env and --no-debug console options (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console optionsThis reverts commit9f60ff8.This reverts commit31b5615.| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28984| License | MIT| Doc PR | -Working on recipes with@weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.Same as#29126, reverts#28745 and#28653Commits-------443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.