Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FWBundle] Automatically enable PropertyInfo when using Flex#28735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ogizanagi commentedOct 5, 2018
It wasn't qualified as a bug in#27429 though |
weaverryan commentedOct 5, 2018
Ohhh. So this was already fixed... but on master. I can see arguments both ways about a bug or a feature. This PR was motivated by me being confused by this yesterday... but it could also be “helped” on 3.4 and 4.1 by adding docs about activating it. |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IIUC, having this in 3.4 is a convenience to help debugging, so not really a bug :)
fabpot commentedOct 6, 2018
Apparently, tests are broken. |
fabpot commentedOct 8, 2018
Thank you@dunglas. |
…ex (dunglas)This PR was merged into the 3.4 branch.Discussion----------[FWBundle] Automatically enable PropertyInfo when using Flex| Q | A| ------------- | ---| Branch? | 3.4 Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License | MIT| Doc PR | n/aAutomatically enabling PropertyInfo when using Flex and when the component is installed has been forgotten when releasing 3.4.It makes it very hard to debug why some features of the serializer are sometimes not working properly.Commits-------0683f0a [FWBundle] Automatically enable PropertyInfo when using Flex
ogizanagi commentedOct 8, 2018
See#28762 for tests |
This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Fix 3.4 tests| Q | A| ------------- | ---| Branch? | 3.4 <!-- see below -->| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes (AppVeyor failure unrelated) <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AShould fix tests on 3.4 branch after#28735 being merged.Also updates the check for consistency withhttps://github.com/symfony/symfony/pull/27429/files#diff-5e7347edce37c5886ec67b7ba02f3a9cR837 on master.Commits-------3b99a0d [FrameworkBundle] Fix 3.4 tests
Automatically enabling PropertyInfo when using Flex and when the component is installed has been forgotten when releasing 3.4.
It makes it very hard to debug why some features of the serializer are sometimes not working properly.