Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] deprecate some options for single_text widgets#28721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@xabbuh
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

@xabbuhxabbuh added this to thenext milestoneOct 4, 2018
@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from3681b21 to29f1dafCompareOctober 4, 2018 10:35
@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from29f1daf to65a765eCompareOctober 4, 2018 11:13
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice move, I like that 👍

@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch 12 times, most recently fromc1bc7a2 tod10e7a7CompareOctober 9, 2018 12:34
fabpot added a commit that referenced this pull requestOct 10, 2018
…ion closure (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#28738).Discussion----------[OptionsResolver] Passing Options argument to deprecation closure| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28721 (comment)| License       | MIT| Doc PR        |symfony/symfony-docs#10439As spotted here#28721, we sometimes need more advanced cases, where the deprecation of the value depends on another option:```php$resolver->setDeprecated('date_format', function (Options $options, $dateFormat) {    if (null !== $options['date_format'] && 'single_text' === $options['widget']) {         return sprintf('Using the "date_format" option of the %s when the "widget" option is set to "single_text" is deprecated since Symfony 4.2.', self::class);    }    return '';});```There is still a decision to make:> We're in time to change the arguments position (Options $options, $value) to be consistent with other closure signatures.WDYT?Commits-------2936051 [OptionsResolver] Passing Options argument to deprecation closure
@xabbuh
Copy link
MemberAuthor

Status: Needs work

@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch fromd10e7a7 to11f32caCompareOctober 10, 2018 11:13
@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from11f32ca to3f951a5CompareOctober 10, 2018 11:14
@xabbuh
Copy link
MemberAuthor

Status: Needs Review

@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from882a4cc to81b3d9aCompareOctober 22, 2018 06:30
@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from81b3d9a toe9cbc61CompareNovember 16, 2018 08:02
@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch 2 times, most recently from241290a to0ab3e8dCompareJanuary 5, 2019 17:01
@xabbuh
Copy link
MemberAuthor

Status: Needs Review

@xabbuhxabbuhforce-pushed thedatetime-type-singletext-deprecations branch from0ab3e8d to89ff331CompareJanuary 16, 2019 23:04
@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit89ff331 intosymfony:masterJan 27, 2019
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
…(xabbuh)This PR was merged into the 4.3-dev branch.Discussion----------[Form] deprecate some options for single_text widgets| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------89ff331 deprecate some options for single_text widgets
@xabbuhxabbuh deleted the datetime-type-singletext-deprecations branchJanuary 27, 2019 19:54
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMar 7, 2019
…iereguiluz)This PR was merged into the master branch.Discussion----------Added a note about the deprecations of DateTimeTypeDocumentssymfony/symfony#28721.Commits-------89f0296 Added a note about the deprecations of DateTimeType
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@ycerutoycerutoyceruto left review comments

@fabpotfabpotfabpot requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh@nicolas-grekas@fabpot@stof@yceruto@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp