Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] deprecate some options for single_text widgets#28721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Form] deprecate some options for single_text widgets#28721
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 4, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
3681b21 to29f1dafCompare29f1daf to65a765eCompare
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice move, I like that 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
c1bc7a2 tod10e7a7Compare…ion closure (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#28738).Discussion----------[OptionsResolver] Passing Options argument to deprecation closure| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28721 (comment)| License | MIT| Doc PR |symfony/symfony-docs#10439As spotted here#28721, we sometimes need more advanced cases, where the deprecation of the value depends on another option:```php$resolver->setDeprecated('date_format', function (Options $options, $dateFormat) { if (null !== $options['date_format'] && 'single_text' === $options['widget']) { return sprintf('Using the "date_format" option of the %s when the "widget" option is set to "single_text" is deprecated since Symfony 4.2.', self::class); } return '';});```There is still a decision to make:> We're in time to change the arguments position (Options $options, $value) to be consistent with other closure signatures.WDYT?Commits-------2936051 [OptionsResolver] Passing Options argument to deprecation closure
xabbuh commentedOct 10, 2018
Status: Needs work |
d10e7a7 to11f32caCompare11f32ca to3f951a5Comparexabbuh commentedOct 10, 2018
Status: Needs Review |
3f951a5 to882a4ccCompareUh oh!
There was an error while loading.Please reload this page.
882a4cc to81b3d9aCompare81b3d9a toe9cbc61Compare241290a to0ab3e8dComparexabbuh commentedJan 5, 2019
Status: Needs Review |
0ab3e8d to89ff331Comparenicolas-grekas commentedJan 27, 2019
Thank you@xabbuh. |
…(xabbuh)This PR was merged into the 4.3-dev branch.Discussion----------[Form] deprecate some options for single_text widgets| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------89ff331 deprecate some options for single_text widgets
…iereguiluz)This PR was merged into the master branch.Discussion----------Added a note about the deprecations of DateTimeTypeDocumentssymfony/symfony#28721.Commits-------89f0296 Added a note about the deprecations of DateTimeType