Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Process] fix locking of pipe files on Windows#28689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.8fromnicolas-grekas:proc-fix
Oct 10, 2018

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28655
LicenseMIT
Doc PR-

@nicolas-grekasnicolas-grekas added this to the2.8 milestoneOct 2, 2018
@nicolas-grekasnicolas-grekas changed the title[Process] fix skipping already used temporary indexes[Process] fix locking of pipe files on WindowsOct 4, 2018
@nicolas-grekas
Copy link
MemberAuthor

@SailorMax patch updated, can you try the new one please?

@SailorMax
Copy link

With new patch all my processes has exitCode = 1 and did not work at all. Can't write stdout and stderr to locked files?

@nicolas-grekasnicolas-grekasforce-pushed theproc-fix branch 3 times, most recently from5848edd to34cc895CompareOctober 5, 2018 07:18
@nicolas-grekas
Copy link
MemberAuthor

Thanks, can you try again please? It should be good now (at least appveyor is green.)

@SailorMax
Copy link

Yes, latest patch work as expected in my case.
Thank you!

@SailorMax
Copy link

But after work temp files remain in the temp-directory. Is it feature? :)

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedOct 5, 2018•
edited
Loading

It is :) Actually there is no way around: unlinking the file would create race conditions.
The compromise here is to use incremental numbers for files so that there should be only a limited number of them to keep in the tmp dir.
We used to use random files to remove any locks, but the outcome was worse: there is no way to delete these tmp files 100% of the time, leading to the tmp dir being filled with empty files on real-world apps. A much worse outcome.

@SailorMax
Copy link

For me - not a problem :)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitd64bd3b intosymfony:2.8Oct 10, 2018
fabpot added a commit that referenced this pull requestOct 10, 2018
…ekas)This PR was merged into the 2.8 branch.Discussion----------[Process] fix locking of pipe files on Windows| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28655| License       | MIT| Doc PR        | -Commits-------d64bd3b [Process] fix locking of pipe files on Windows
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@SailorMax@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp