Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options#28653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromchalasr:depr-nodebug-env-opts
Oct 3, 2018

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedSep 30, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?n/a
Deprecations?yes
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

See#23343 (comment)

dunglas, fbourigault, and eerison reacted with thumbs up emojistloyd, Shine-neko, metfan, dmaicher, iquito, BoShurik, tristanbes, Kocal, flackovic, sweoggy, and 3 more reacted with confused emoji
@chalasrchalasr added this to thenext milestoneSep 30, 2018
@chalasrchalasrforce-pushed thedepr-nodebug-env-opts branch 4 times, most recently from48a49e1 to2f92fddCompareSeptember 30, 2018 19:48
@chalasrchalasr changed the title[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options[Console] Deprecate the "--env" and "--no-debug" optionsSep 30, 2018
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should add a note in the UPGRADE/CHANGELOG files

@chalasrchalasr changed the title[Console] Deprecate the "--env" and "--no-debug" options[FrameworkBundle] Deprecate the "--env" and "--no-debug" console optionsOct 1, 2018
@chalasr
Copy link
MemberAuthor

@fabpot done, thanks for the reminder.
Also moved to FrameworkBundle, I've been confused by the console recipe relying on them.

@chalasrchalasrforce-pushed thedepr-nodebug-env-opts branch 4 times, most recently from161ea03 to654aa3fCompareOctober 1, 2018 21:50
* Added support for the SameSite attribute for session cookies. It is highly recommended to set this setting (`framework.session.cookie_samesite`) to `lax` for increased security against CSRF attacks.
* The `ContainerAwareCommand` class has been removed, use `Symfony\Component\Console\Command\Command`
with dependency injection instead.
* The `--env` console option and its "-e" shortcut have been deprecated,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In 5.0 this option would removed.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

good catch, fixed

@chalasrchalasr modified the milestones:next,4.2Oct 2, 2018
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit9f60ff8 intosymfony:masterOct 3, 2018
fabpot added a commit that referenced this pull requestOct 3, 2018
…g" console options (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] Deprecate the "--env" and "--no-debug" console options| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | n/a| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aCommits-------9f60ff8 [FrameworkBundle] Deprecate the "--env" and "--no-debug" options
@chalasrchalasr deleted the depr-nodebug-env-opts branchOctober 3, 2018 08:53
@weaverryan
Copy link
Member

weaverryan commentedOct 7, 2018•
edited
Loading

Can you open a docs issue / pr?

@chalasr
Copy link
MemberAuthor

@weaverryan sorry, forgot about it. Just openedsymfony/symfony-docs#10444

@gnugat
Copy link
Contributor

Hi, I can't seem to be able to find any explanations on this decision, is there a link to a discussion about it somewhere I could be pointed to?

AlsoBC breaks? has been set asn/a, shouldn't it have been set to "yes" as in Sf 5 scripts using the flag won't be working anymore? Or is it a "no" as currently the only thing we have is warning notice?

Thanks for you answers, and keep up the good work.

Kocal, silvesterk, AlexKlymenkoWork, and dmaicher reacted with thumbs up emojikwielo reacted with heart emoji

@ogizanagi
Copy link
Contributor

ogizanagi commentedOct 8, 2018•
edited
Loading

@gnugat : This was discussed a bit a long time ago.Here is a comment from Fabien mentioning this.
Note there is no BC break here, as it's still supported until 5.0. It'll be considered a BC break when removing it at timemaster becomes the v5 branch. For now, this is only a deprecation.

@gnugat
Copy link
Contributor

@ogizanagi thanks for the link, that's exactly what I was looking for (the description in this PR was empty). Also thanks for the explanation on the BC break policy 👍

@chalasr
Copy link
MemberAuthor

@gnugat link added to the PR body, sorry about that

@c33s
Copy link

this is really a bad decision, it makes the use on windows much more complicated. this is really a very bad DX.

php bin/console --env=devSymfony 3.4.12 (kernel: src, env: dev, debug: true)(fully working symfony console with no errors)

vs

APP_ENV=dev php bin\console'APP_ENV' is not recognized as an internal or external command,operable program or batch file.

vs

λ cmd /V /C "set APP_ENV=dev&& php bin\console" [WARNING] Some commands could not be registered:In EnvVarProcessor.php line 76:  Environment variable not found: "DATABASE_URL_LEGACY".Symfony 3.4.12 (kernel: src, env: dev, debug: true)---snip---In EnvVarProcessor.php line 76:  Environment variable not found: "APP_SECRET".

also the handy autocomplete possibility with clink on windows and bash-completion on linux is gone with this change. environment variables are cool but not the holy grail for everything. there is a reason for having flags on commands. imagine you have to call all commands like this:

URL=http://example.com RECURSIVE=true OUTPUT_FILE=foo.html wget

please revert this.

@nicolas-grekas
Copy link
Member

@c33s can you please open a separate issue? Commenting on anything closed is likely going to get low traction.

@nicolas-grekas
Copy link
Member

Reverted in#29204

nicolas-grekas added a commit that referenced this pull requestNov 14, 2018
…-env and --no-debug console options (chalasr)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console optionsThis reverts commit9f60ff8.This reverts commit31b5615.| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28984| License       | MIT| Doc PR        | -Working on recipes with@weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.Same as#29126, reverts#28745 and#28653Commits-------443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

+2 more reviewers

@KocKocKoc left review comments

@jvasseurjvasseurjvasseur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

12 participants

@chalasr@fabpot@weaverryan@gnugat@ogizanagi@c33s@nicolas-grekas@dunglas@Koc@jvasseur@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp