Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PHPUnitBridge] Fix ClockMock microtime() format#28648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@acasademont
Copy link
Contributor

@acasademontacasademont commentedSep 30, 2018
edited by nicolas-grekas
Loading

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?no
Fixed tickets-
LicenseMIT
Doc PR-

This is a follow-up PR to#27890 to fix themicrotime precision, it should be 8 decimals instead of the current 6 (seehttps://3v4l.org/GYacF)

The problem now is that due to the new tests the whole testsuite will fail if run from the main directory, as hhvm and 5.4 targets are doing, due to phpunit using the wrongClockMock class. Tests for 7.1 and 7.2 pass because theycd into the component directory.

@acasademontacasademont changed the title[PHPUnitBridge] Fix microtime() format[PHPUnitBridge] Fix ClockMock microtime() formatSep 30, 2018
@nicolas-grekasnicolas-grekas added this to the2.8 milestoneSep 30, 2018
@nicolas-grekas
Copy link
Member

Thank you@acasademont.

@nicolas-grekasnicolas-grekas merged commite3732b6 intosymfony:2.8Oct 2, 2018
nicolas-grekas added a commit that referenced this pull requestOct 2, 2018
…ont)This PR was merged into the 2.8 branch.Discussion----------[PHPUnitBridge] Fix ClockMock microtime() format| Q             | A| ------------- | ---| Branch?       | 2.8 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | no    <!-- please add some, will be required by reviewers -->| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | <!-- required for new features -->This is a follow-up PR to#27890 to fix the `microtime` precision, it should be 8 decimals instead of the current 6 (seehttps://3v4l.org/GYacF)The problem now is that due to the new tests the whole testsuite will fail if run from the main directory, as hhvm and 5.4 targets are doing, due to phpunit using the wrong `ClockMock` class. Tests for 7.1 and 7.2 pass because they `cd` into the component directory.Commits-------e3732b6 [PHPUnitBridge] Fix microtime() format
This was referencedOct 3, 2018
@fabpotfabpot mentioned this pull requestNov 3, 2018
@acasademontacasademont deleted the fix_microtime_format branchFebruary 26, 2019 14:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

3 participants

@acasademont@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp